Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/inject namespace required for kustomize #24

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Dec 2, 2024

Description

Pull Request Description

Motivation

This pull request introduces the necessary changes to inject the namespace required for Kustomize into the Kerberos.io Helm charts. By explicitly defining the namespace for each resource, we ensure that the Helm charts are compatible with Kustomize and can be deployed consistently across different environments. This change enhances the flexibility and robustness of our deployment process.

Changes Overview

  1. Namespace Injection:

    • Added namespace: {{ .Release.Namespace }} to all relevant Kubernetes resource templates within the Helm charts. This ensures that resources are created in the correct namespace as specified during the Helm release.
  2. Ingress Class Annotation Update:

    • Replaced the deprecated kubernetes.io/ingress.class annotation with ingressClassName to align with the latest Kubernetes best practices.
  3. Version Bump:

    • Updated the chart version from 0.74.0 to 0.75.0 to reflect the changes and ensure proper versioning for Helm deployments.
  4. Documentation Fix:

    • Corrected a minor formatting issue in the README file for better readability.

Benefits

  • Compatibility with Kustomize: Ensures that the Helm charts can be seamlessly used with Kustomize, enhancing deployment flexibility.
  • Namespace Consistency: Explicit namespace definition helps avoid potential issues related to resource creation in unintended namespaces.
  • Modern Practices: Updating the ingress class annotations to the recommended ingressClassName ensures compatibility with current and future Kubernetes versions.
  • Versioning: Proper versioning allows users to track changes and updates effectively, ensuring smooth upgrades and maintenance.

By implementing these changes, we improve the overall deployment process, making it more reliable and adaptable to various deployment tools and environments.

@cedricve cedricve self-assigned this Dec 2, 2024
@cedricve cedricve merged commit 4a77442 into main Dec 2, 2024
9 checks passed
@cedricve cedricve deleted the feature/inject-namespace-required-for-kustomize branch December 2, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant